Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Optimise implementation for indexing genesis accounts balance #2012

Conversation

nagdahimanshu
Copy link
Contributor

@nagdahimanshu nagdahimanshu commented Jan 9, 2024

What was the problem?

This PR resolves #2011

How was it solved?

  • Index accounts token balance while indexing genesis assets parallel in batches
  • Add error handling for
    • ensureAPIClientLiveness
    • New/Delete block and new transaction event in connector
    • getAllPosValidators
  • Avoid extra calls to the node
  • Fix issue with event subscription

How was it tested?

Local + Server against both networks (mainnet and testnet)

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b83e921) 68.07% compared to head (59175fe) 68.07%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2012   +/-   ##
============================================
  Coverage        68.07%   68.07%           
============================================
  Files              299      299           
  Lines             5344     5344           
  Branches           977      977           
============================================
  Hits              3638     3638           
  Misses            1706     1706           

@nagdahimanshu nagdahimanshu force-pushed the 2011-optimise-implementation-for-indexing-genesis-accounts-balance branch from 80a19d5 to 9ad502b Compare January 9, 2024 10:28
@nagdahimanshu nagdahimanshu force-pushed the 2011-optimise-implementation-for-indexing-genesis-accounts-balance branch from db6e479 to b730808 Compare January 9, 2024 12:55
@sameersubudhi sameersubudhi force-pushed the 2011-optimise-implementation-for-indexing-genesis-accounts-balance branch from 407cc94 to 59175fe Compare January 10, 2024 12:20
@nagdahimanshu nagdahimanshu marked this pull request as ready for review January 10, 2024 13:01
Copy link
Contributor

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sameersubudhi sameersubudhi merged commit fd43e2f into development Jan 10, 2024
10 checks passed
@sameersubudhi sameersubudhi deleted the 2011-optimise-implementation-for-indexing-genesis-accounts-balance branch January 10, 2024 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimise implementation for indexing genesis accounts balance
2 participants